Skip to content

Conversation

@kjs104901
Copy link
Contributor

@kjs104901 kjs104901 commented Feb 21, 2024

Our Perforce server has been operational since July 2, 2013, and the current changelist number is 1524832.

Normally, using changes -m is efficient for both users and build machines due to our optimization settings.
(For more details, see Server performance related to 'p4 changes').

However, retrieving changes for a specific client and revision is significantly slower
(changes -m1 //clientname/...@Rev).
This slowdown affects the plugin's ability to determine the latest changelist number for clients.

I believe that setting a revision range for changes is not essential, and omitting it could enhance performance.
According to the documentation, optimizations are most effective when not restricted by revision specifications.

I have already implemented this change in our Jenkins setup, and it has shown positive results.

Before
image

After
image

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@skumar7322
Copy link
Contributor

Thanks @kjs104901 for creating this PR to improve P4-Plugin. Will take up this in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants