Skip to content

Conversation

@strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Feb 28, 2025

Require Jenkins 2.479.3 and Jakarta EE 9

Jenkins 2.479.3 provides Jakarta EE 9, Eclipse Jetty 12, Spring Security 6, and Java 17.

  • Update plugin pom and baseline
  • Remove deprecations
  • Use Java 17 language features
  • Minor cleanup

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd changed the title Migrate Require Jenkins 2.479.1 and Jakarta EE 9 Feb 28, 2025
@strangelookingnerd strangelookingnerd changed the title Require Jenkins 2.479.1 and Jakarta EE 9 Require Jenkins 2.479.3 and Jakarta EE 9 Apr 23, 2025
@strangelookingnerd
Copy link
Contributor Author

@stuartrowe Kindly requesting a review.

@stuartrowe
Copy link
Contributor

@strangelookingnerd I'm not a maintainer of this plugin so I don't think I'm qualified to review it.

@skumar7322 would be the best to review it.

@skumar7322
Copy link
Contributor

Hi @strangelookingnerd thanks for creating this PR.
There are too many files in this PR. If possible could you please break this in multiple PRs(max 30 files per commit).
The decision to update Jenkins version is taken by us, after analysing the number of impacted users. Remove Jenkins version and java version changes.
Really appreciate you efforts for these changes.

@strangelookingnerd
Copy link
Contributor Author

9a7e8e8 contains the most important changes that are more or less required.

b60493d contains changes that are optional to a certain extent, however I'd highly recommend considering them to improve code quality and maintainability. I don't see the point of breaking that up into smaller commits.

@skumar7322
Copy link
Contributor

I will run our test suite for this PR.

rantoniuk referenced this pull request Aug 9, 2025
Resolve the folder properties used in P4Plugin for FreeStyle, Pipeline and MultiBranch project configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants