-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag include and exclude options #28
base: master
Are you sure you want to change the base?
Conversation
This works the same way as --include and --exclude of the robot command line utility. It can be used for example for filtering out skipped tests, that were marked with a specific tag Signed-off-by: Joerg Vehlow <[email protected]>
Hi, Thanks for contributing! Could you illuminate me a bit about what is the intended use case for this feature? Refining the RF log/report that the plugin then publishes is already directly built-in in Robot's What does this functionality in the plugin add to that? |
As I already described in the commit message, it can be used to exclude skipped tests. If there are different reasons for skipping tests, it could be required for the output.xml to still contain all tests, including skipped ones, for later analysis. That is actually the use case, this pr is designed to solve. I could imagine, there are also other use cases, like leaving known failing tests or tests drafts out of the statistics while still keeping them in the log for analysis. |
So it just replicates functionality in Robot Framework itself (as I previously linked)? |
Yes, but it moves the responsibility where it belongs. If the visualized data should be reduced only in jenkins, it should be part of the plugin and not any preprocessing step. If it was done in preprocessing, the full results are not available anymore (or require another archived file). So there is a big difference between preprocessing and doing it in jenkins |
I would encourage you to reread what I feel this plugin's core tenent is to provide functionality that adds to Robot Framework's. |
I do know, that it can be done using rebot. It is just inconvenient to do it using rebot in some cases. Imagine a more complicate use case, where jenkins does not do the build itself and maybe even has no access to rebot. |
BTW I am not the first one with this requirement. See https://issues.jenkins-ci.org/browse/JENKINS-8378 |
I appreciate this pr. Would be really helpful. |
This works the same way as --include and --exclude of the
robot command line utility.
It can be used for example for filtering out skipped tests,
that were marked with a specific tag
Signed-off-by: Joerg Vehlow [email protected]
I am willing to add unit tests as well, if this PR gets attention