Call GroovyClassLoader.close when build completes
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is a special loader as of #120. Should not matter for purposes of this PR I guess. |
dwnusbaum
approved these changes
Mar 2, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1 task
jglick
added a commit
to jglick/pipeline-groovy-lib-plugin
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When considering loading libraries from JAR files in jenkinsci/pipeline-groovy-lib-plugin#55 it occurred to me that a completed build might leave classpath JAR files open at least until garbage collection, which could be a problem particularly on Windows. Might also affect Grape users. Safest to close these deterministically. Untested beyond the many functional tests in this plugin.