Skip to content

docs: configuration_eval -> configuration_module_eval #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

bjeanes
Copy link
Contributor

@bjeanes bjeanes commented Feb 23, 2025

I was looking at the docs for custom features today and noted an example usage of configuration_eval. I wasn't totally sure how it should be used so searched the source for it and couldn't find any usages. Digging into the source code and the commit which introduced this term to the changelog and README, I think this was a typo for configuration_module_eval.

@jeremyevans
Copy link
Owner

Thank you for the fix. The method was probably named configuration_eval at some point during development, but changed to configuration_module_eval before it was committed.

@jeremyevans jeremyevans merged commit 7f9404a into jeremyevans:master Feb 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants