Cw test #13
Closed
Cw test #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12781 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the v1-beta samples for the schema-registry package to align with modern TypeScript sample standards and updates various dependencies.
- Modernizes TypeScript sample configuration (target ES2023, node10 resolution, stricter compiler options)
- Updates import statements to use type imports for better tree-shaking
- Updates dependencies (@azure/identity, TypeScript, typespec-client-generator-cli)
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/schemaregistry/schema-registry/samples/v1-beta/typescript/tsconfig.json | Updated to modern sample tsconfig standards (ES2023, node10 resolution, stricter options) |
| sdk/schemaregistry/schema-registry/samples/v1-beta/typescript/src/schemaRegistrySample.ts | Updated imports to use type imports for SchemaDescription, reformatted dotenv import, added trailing comma |
| sdk/schemaregistry/schema-registry/samples/v1-beta/typescript/src/getSchemaByVersion.ts | Updated imports to use type imports for SchemaDescription, reformatted dotenv import, added trailing comma |
| sdk/schemaregistry/schema-registry/samples/v1-beta/typescript/sample.env | Removed outdated Azure AD service principal authentication comments |
| sdk/schemaregistry/schema-registry/samples/v1-beta/typescript/package.json | Updated @azure/identity to 4.11.1, TypeScript to 5.9.3, added cross-env |
| sdk/schemaregistry/schema-registry/samples/v1-beta/typescript/README.md | Added query parameter to API reference URL for preview documentation view |
| sdk/schemaregistry/schema-registry/samples/v1-beta/javascript/schemaRegistrySample.js | Updated dotenv import to use dotenv/config, added trailing comma |
| sdk/schemaregistry/schema-registry/samples/v1-beta/javascript/sample.env | Removed outdated Azure AD service principal authentication comments |
| sdk/schemaregistry/schema-registry/samples/v1-beta/javascript/package.json | Updated @azure/identity to 4.11.1, added cross-env devDependency |
| sdk/schemaregistry/schema-registry/samples/v1-beta/javascript/getSchemaByVersion.js | Updated dotenv import to use dotenv/config, added trailing comma |
| sdk/schemaregistry/schema-registry/samples/v1-beta/javascript/README.md | Added query parameter to API reference URL for preview documentation view |
| eng/common/tsp-client/package.json | Updated typespec-client-generator-cli from 0.29.0 to 0.30.0 |
| eng/common/tsp-client/package-lock.json | Updated package-lock with new typespec-client-generator-cli version |
Files not reviewed (1)
- eng/common/tsp-client/package-lock.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.