fix creation of sensor groups #580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- async methods need to be awaited to work properly
|
It seems, that quite a lot of async method calls are missing the "await". |
|
I distinctly thought we got all of them, but apparently not... Feel free to expand your PR to take care of these. |
|
There are several other places. I can try to fix them, too. But for this I would rather go for a proper dev setup to test it. |
|
If you give me pointers, I can fix them quickly |
|
Just search for "async_" in the init.py. I found there several async methods which are called without being awaiting for them. I haven't checked other files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the problem, that I could not add any new sensor groups. Looking at the HA logs, I figured out that "await" was missing for two async method calls.