Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut (Ctrl+L) to clear logs #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunny-Ne5
Copy link

@sunny-Ne5 sunny-Ne5 commented Jul 19, 2023

Fix #403

@sunny-Ne5 sunny-Ne5 changed the title Fix #403: Clear logs Add shortcut (Ctrl+L) to clear logs Jul 19, 2023
@jesseduffield
Copy link
Owner

Looking good. Two things:

  • Could we make this keybinding also available in the side views that render to the main view? I'd prefer to not have to hit enter in order to press ctrl+l
  • Looks like the keybinding isn't rendered properly in the keybindings menu (which you get upon pressing '?'
image

Looks like we need to add a special key to the switch statement in GetKey() in pkg/gui/keybindings.go

@sunny-Ne5
Copy link
Author

  • Could we make this keybinding also available in the side views that render to the main view? I'd prefer to not have to hit enter in order to press ctrl+l

Should we enable this keybinding for "Containers" or for other side views as well? For this I was planning to add one more entry to GetInitialKeybindings() in keybindings.go. Let me know if there is a better way to do it if it's repetitive.

*Looks like the keybinding isn't rendered properly in the keybindings menu (which you get upon pressing '?'
Is this good?
image

@jesseduffield
Copy link
Owner

@sunny-Ne5 Sorry for the late reply! You'll only need the keybinding for containers and services, so feel free to just add an extra two keybindings for that

@peauc
Copy link

peauc commented Jun 15, 2024

I want to take a look at this PR to move it forward.
@sunny-Ne5, are you still interested in this PR, you don't mind ?

@sunny-Ne5
Copy link
Author

sunny-Ne5 commented Jun 16, 2024 via email

@peauc peauc mentioned this pull request Jun 16, 2024
@peauc
Copy link

peauc commented Jun 16, 2024

I've pulled your changed and have started a branch 👍. Thanks

@peauc
Copy link

peauc commented Jun 16, 2024

@jesseduffield requested changes have been made in my pull request 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear logs
3 participants