Container logs filtering#732
Open
ManManavadaria wants to merge 2 commits intojesseduffield:masterfrom
Open
Conversation
…r, Implemented the stream filtering code to support both tty and non-tty logs with ASCII filter support, Refactor filtering code to support both list filter and logs filter, Added new views for log filter with its new keybindings
Contributor
Author
|
I opened this PR a while ago to add log filtering feature. I just wanted to gently follow up. Whenever you have a chance, I’d really appreciate it if you could take a look and share your thoughts. If the approach or feature isn’t aligned with the project’s direction, I’d be happy to revise it or close the PR accordingly. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
This PR adds the ability to filter on container logs by pressing the key '/' while the Logs tab is in focus
Motivation
I think this feature is practically useful because while working on containers with large volume of logs, it can be difficult to quickly find relevant entries. This feature enables filtering without changing context, eliminating the need to scroll through large log streams or switch scope to run docker logs | grep commands
Closes #655
Changes
/while viewing logs)