Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a Docker API version negotiation issue where users encountered "client version 1.25 is too old" errors when the DOCKER_API_VERSION environment variable was set. The fix replaces the use of client.FromEnv with a custom newDockerClient function that properly enables API version negotiation.
Changes:
- Introduced a new
newDockerClienthelper function that explicitly configures the Docker client without version locking - Updated
NewDockerCommandto use the new helper function instead ofclient.FromEnv - Added comprehensive regression tests to verify version negotiation behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/commands/docker.go | Added newDockerClient function to create Docker clients with proper API version negotiation and updated NewDockerCommand to use it |
| pkg/commands/docker_test.go | Added regression test that verifies version negotiation works correctly when DOCKER_API_VERSION is set |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jesseduffield
force-pushed
the
fix-version-lock
branch
from
f613e9c to
3c9d134
Compare
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 17, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazydocker](https://github.com/jesseduffield/lazydocker) | patch | `v0.24.3` → `v0.24.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazydocker (jesseduffield/lazydocker)</summary> ### [`v0.24.4`](https://github.com/jesseduffield/lazydocker/releases/tag/v0.24.4) [Compare Source](jesseduffield/lazydocker@v0.24.3...v0.24.4) #### Changelog - [`3c9d134`](jesseduffield/lazydocker@3c9d134) Fix version lock issue - [`577797d`](jesseduffield/lazydocker@577797d) Merge pull request [#​744](jesseduffield/lazydocker#744) from jesseduffield/fix-version-lock </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44Mi4zIiwidXBkYXRlZEluVmVyIjoiNDIuODIuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #715