Fix #752: Network containers showing 'none' in config panel#766
Open
rodionsteshenko wants to merge 1 commit intojesseduffield:masterfrom
Open
Fix #752: Network containers showing 'none' in config panel#766rodionsteshenko wants to merge 1 commit intojesseduffield:masterfrom
rodionsteshenko wants to merge 1 commit intojesseduffield:masterfrom
Conversation
NetworkList returns network.Summary which doesn't include container details in the Containers field. This causes the network config panel to always show 'Containers: none' even when containers are connected to the network. Fix by calling NetworkInspect for each network during refresh to get the full inspect data including connected containers. Fixes jesseduffield#752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: NetworkList API returns network.Summary which doesn't populate Containers. Switched to NetworkInspect which returns the full network resource including container mappings. Clean one-file fix in pkg/commands/network.go. Tested on macOS ARM (Apple Silicon).