fix: Freeze when pressing o when with project pane selected - shoul...#768
Open
bintocher wants to merge 1 commit intojesseduffield:masterfrom
Open
fix: Freeze when pressing o when with project pane selected - shoul...#768bintocher wants to merge 1 commit intojesseduffield:masterfrom
bintocher wants to merge 1 commit intojesseduffield:masterfrom
Conversation
Use non-blocking cmd.Start() with goroutine for Wait() instead of synchronous RunCommand() in OpenFile and OpenLink methods. Fixes jesseduffield#688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a freeze when pressing 'o' with the project pane selected by making file and link opening operations asynchronous. Previously, the
OpenFileandOpenLinkfunctions used blocking command execution, which caused the UI to hang until the opened application closed.Issue
Fixes #688
Changes
OpenFileto use asynchronous command execution withcmd.Start()andgo cmd.Wait()instead of blockingRunCommandOpenLinkto use the same asynchronous pattern for consistencyTesting