fix: show containers in network config view#773
Open
umut-polat wants to merge 1 commit intojesseduffield:masterfrom
Open
fix: show containers in network config view#773umut-polat wants to merge 1 commit intojesseduffield:masterfrom
umut-polat wants to merge 1 commit intojesseduffield:masterfrom
Conversation
NetworkList does not populate the Containers field in the response. When viewing a network's config, the Containers section always showed 'none' regardless of how many containers were attached. Use NetworkInspect to fetch full network details including connected containers when rendering the config panel. Fixes jesseduffield#752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting a network, the config panel always shows
Containers: noneeven when containers are attached to it.The
NetworkListAPI doesn't populate theContainersfield — onlyNetworkInspectdoes. The config renderer was reading from the list response, which is always empty.Added a
Network.Inspect()method and call it when rendering the config panel to fetch the full network details including connected containers.Fixes #752