fix: improve error message when git is not installed#5189
Closed
YuriNachos wants to merge 1 commit intojesseduffield:masterfrom
Closed
fix: improve error message when git is not installed#5189YuriNachos wants to merge 1 commit intojesseduffield:masterfrom
YuriNachos wants to merge 1 commit intojesseduffield:masterfrom
Conversation
When git is not installed at all, show a more helpful message instead of suggesting to upgrade git version. Fixes jesseduffield#5028
Collaborator
|
As discussed here, this is not worth the added complexity. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
GitNotInstalledErrortranslation key inpkg/i18n/english.goisGitNotInstalledError()helper function inpkg/app/app.govalidateGitVersion()to check error type and show appropriate messageMotivation
Fixes #5028 - the error message was confusing when git wasn't installed at all
Test manual
Checklist
go build)gofumpt