fix: preserve commit message when canceling reword mode #5190
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rto reword a commit message and pressing ESC, the message is now preservedPreserveMessage: false→PreserveMessage: trueChanges
reword()method inpkg/gui/controllers/local_commits_controller.goPreserveMessageflag fromfalsetotrueMotivation
Fixes #5183 - users often need to press ESC to look at changes while editing a commit message, and the message was lost when returning to reword mode
Test manual
r(reword)ESCrExpected: Message "Test message 123" is present ✅
Behavior note
.git/LAZYGIT_PENDING_COMMIT(same file as normal commit)Checklist
go build)gofumpt