Skip to content

Conversation

@jessegrabowski
Copy link
Owner

@jessegrabowski jessegrabowski commented Sep 7, 2025

Clean up the codebase using stricter ruff rules.

Several files need more systematic refactor as a result. These files were excluded from certain rules (C901, PLR0912, PLR0915, PLR2004). These should be addressed at some point, and the excludes should be removed.


📚 Documentation preview 📚: https://gEconpy--56.org.readthedocs.build/en/56/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 72.97619% with 227 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.41%. Comparing base (abb1b3e) to head (6001d7a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
gEconpy/plotting.py 66.52% 79 Missing ⚠️
gEconpy/model/model.py 74.74% 49 Missing ⚠️
gEconpy/solvers/gensys.py 51.78% 27 Missing ⚠️
gEconpy/model/statespace.py 64.28% 15 Missing ⚠️
gEconpy/utilities.py 46.15% 14 Missing ⚠️
gEconpy/numbaf/overloads.py 30.00% 7 Missing ⚠️
gEconpy/model/perturbation.py 57.14% 6 Missing ⚠️
gEconpy/numbaf/intrinsics.py 28.57% 5 Missing ⚠️
gEconpy/parser/parse_distributions.py 71.42% 4 Missing ⚠️
gEconpy/model/steady_state.py 78.57% 3 Missing ⚠️
... and 12 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   75.29%   76.41%   +1.12%     
==========================================
  Files          33       33              
  Lines        4857     4872      +15     
==========================================
+ Hits         3657     3723      +66     
+ Misses       1200     1149      -51     
Files with missing lines Coverage Δ
gEconpy/__init__.py 77.77% <100.00%> (ø)
gEconpy/classes/containers.py 97.84% <100.00%> (-0.01%) ⬇️
gEconpy/model/compile.py 100.00% <100.00%> (ø)
gEconpy/model/simplification.py 98.43% <100.00%> (+0.07%) ⬆️
gEconpy/parser/constants.py 100.00% <100.00%> (ø)
gEconpy/parser/gEcon_parser.py 98.47% <100.00%> (-0.02%) ⬇️
gEconpy/parser/parse_plaintext.py 98.43% <100.00%> (-0.10%) ⬇️
gEconpy/solvers/cycle_reduction.py 91.81% <100.00%> (-0.15%) ⬇️
gEconpy/solvers/shared.py 100.00% <100.00%> (ø)
gEconpy/classes/time_aware_symbol.py 93.22% <87.50%> (+3.82%) ⬆️
... and 21 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jessegrabowski jessegrabowski merged commit da495b2 into main Sep 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants