more fault tolerant for shell setting (#1100)

* more fault tolerant for shell setting * fix ci check
jest-community · Jan 13, 2024 · f867798 · f867798
1 parent b3f78ed
commit f867798
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/JestExt/run-shell.ts b/src/JestExt/run-shell.ts
@@ -41,7 +41,7 @@ export class RunShell {
         this.nonLoginShell = setting;
         this.loginShell = this.getLoginShell(setting);
       } else {
-        if (setting.args.length > 0) {
+        if (setting.args?.length > 0) {
           this._useLoginShell = true;
           this.nonLoginShell = undefined;
           this.loginShell = setting;

diff --git a/tests/JestExt/run-shell.test.ts b/tests/JestExt/run-shell.test.ts
@@ -30,6 +30,7 @@ describe('RunnerShell', () => {
       ${6} | ${'darwin'} | ${{ path: 'bash', args: ['--login'] }} | ${{ path: 'bash', args: ['--login'] }} | ${true}       | ${undefined}
       ${7} | ${'linux'}  | ${undefined}                           | ${LoginShells.sh}                      | ${false}      | ${undefined}
       ${8} | ${'linux'}  | ${'whatever'}                          | ${undefined}                           | ${'never'}    | ${undefined}
+      ${9} | ${'darwin'} | ${{ path: '/bin/zsh' }}                | ${LoginShells.zsh}                     | ${false}      | ${'/bin/zsh'}
     `('case $case', ({ platform, setting, loginShell, settingOverride, useLoginShell }) => {
       jest.clearAllMocks();
       mockPlatform.mockReturnValue(platform);