docs: update README.md fix jest run mode type #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix jest run mode type
kota-kamikawa
changed the title
kota-kamikawa
changed the title
connectdotz
reviewed
Mar 12, 2024
README.md
Outdated
| @@ -519,7 +519,7 @@ The following are the predefined `runMode` configurations for convenience. They | |||
| |Predefined runMode|Description|JestRunMode| | |||
| |:---:|---|---| | |||
| |"watch"| run tests by watchman | {type: "watch", revealOutput: "on-run"} | | |||
There was a problem hiding this comment.
Hi, thanks for bringing this to our attention. It turns out this section has even more outdated information😓: there is no longer a revealOutput attribute. Would you mind removing all the revalOutput as well while you are at it? Thanks!
There was a problem hiding this comment.
@connectdotz
Thank you for the review, I have deleted it!
connectdotz
approved these changes
Mar 13, 2024
Pull Request Test Coverage Report for Build 8258769281Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated following section of the README file. Please review it!