-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat(examples): replace react-test-renderer reference with @testing-library/react for snapshot testing
#15806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): replace react-test-renderer reference with @testing-library/react for snapshot testing
#15806
Conversation
…g-library/react` for snapshot testing Signed-off-by: hainenber <[email protected]>
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
cpojer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks for this!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Partially addresses #15150
I was contemplating replacing
react-test-rendererusage in React Native snapshot testing with its equivalent,@testing-library/react-nativebut the latter still use the former underneath so it's pointless to do so.Regarding
react-test-rendererusage inpretty-format, it was used as a dev dep and eventually that is an implicit dependency. I reckon we'll need to mark theReactTestComponentvalue inpluginoption to be deprecated before removing all of related tests. That's probably a major version bump forpretty-formatthough so not now afaics.Test plan
Green CI