chore: Upgrade chart version to 0.4.0 for jetstack-agent #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawksight
force-pushed
the
jetstack-agent-0-3-2
branch
from
99e6d70 to
c5b0372
Compare
aidy
reviewed
Jun 24, 2024
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: jetstack-agent | |||
| description: TLS Protect for Kubernetes Agent | |||
| type: application | |||
| version: 0.3.1 | |||
| version: 0.3.2 | |||
There was a problem hiding this comment.
This is bumping the hotfix/patch version, not the minor version.
imo, this should be a minor version (0.4.0), but if you've already cut a 0.3.2 release, or if you really want it to be 0.3.2, I'm not feeling particularly pedantic today.
There was a problem hiding this comment.
I'm easy. I have not cut a release (create from master manually after merging).
Minor encompases new features correct?
Patch is just fixing existing features?
Happy to change to keep this right, just checking it is right.
Signed-off-by: Peter <[email protected]>
hawksight
force-pushed
the
jetstack-agent-0-3-2
branch
from
c5b0372 to
084763a
Compare
hawksight
changed the title
aidy
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minor version to release the chart change to be able to add Volumes & VolumeMounts from #540.