[VC-35373] Add missing VenafiConnection templates and values to the Helm chart #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallrj
force-pushed
the
VC-35373-venafi-connection-helm-chart
branch
from
36cce94 to
396bdd6
Compare
maelvls
force-pushed
the
venconn
branch
2 times, most recently
from
3833300 to
aadc8b2
Compare
wallrj
force-pushed
the
VC-35373-venafi-connection-helm-chart
branch
from
396bdd6 to
36f97a0
Compare
wallrj
commented
Aug 20, 2024
deploy/charts/venafi-kubernetes-agent/templates/venafi-connection-crd.yaml
Outdated
Show resolved
Hide resolved
deploy/charts/venafi-kubernetes-agent/templates/venafi-connection-crd.without-validations.yaml
Outdated
Show resolved
Hide resolved
deploy/charts/venafi-kubernetes-agent/templates/_venafi-connection.tpl
Outdated
Show resolved
Hide resolved
…on-lib The venafi-connection-lib library uses more recent versions of the dependencies in the Venafi Kubernetes Agent. When I ran export GOPRIVATE=github.com/jetstack go get github.com/jetstack/venafi-connection-lib@latest most of the dependencies in this project got updated. This commit captures these changes.
…n=name I've also added the flag --venafi-connection-namespace as well as the flag --install-namespace that is only needed when running the agent out-of-cluster (this is only useful for testing purposes).
Let's pin venafi-connection-lib to the latest commit on main until we decide to release a new version of venafi-connection-lib (if we actually do).
maelvls
reviewed
Aug 20, 2024
wallrj
force-pushed
the
VC-35373-venafi-connection-helm-chart
branch
from
5fca3a3 to
b3e1b53
Compare
maelvls
force-pushed
the
venconn
branch
2 times, most recently
from
f162ad7 to
4f368fa
Compare
wallrj
force-pushed
the
VC-35373-venafi-connection-helm-chart
branch
from
b3e1b53 to
87817e2
Compare
maelvls
force-pushed
the
venconn
branch
12 times, most recently
from
83a2190 to
4ec8495
Compare
maelvls
force-pushed
the
venconn
branch
4 times, most recently
from
998019a to
388949e
Compare
wallrj
force-pushed
the
VC-35373-venafi-connection-helm-chart
branch
2 times, most recently
from
86c9b2f to
c9f05bb
Compare
Note that I should probably have gone with a fake of the ConnectionHandler instead of an envtest. We will move to the fake later on. I added the venaficonnection CRDs manually for now. I have a PR to automate pulling these CRDs from the venafi-connection-lib project: jetstack#556 For now, I added these manifests manually with the following commands: gh pr checkout 556 git checkout - git checkout step1-makefile-modules -- deploy/charts/venafi-kubernetes-agent/templates/venafi-connection-crd{,.without-validations}.yaml
Not sure why or who is adding this line, probably "go work init". I don't know whether it would be useful, either. Also, the version "go 1.22.0" was causing errors in CI [1]: ``` go: errors parsing go.mod: /__w/jetstack-secure/jetstack-secure/go.mod:3: invalid go version '1.22.0': must match format 1.23 /__w/jetstack-secure/jetstack-secure/go.mod:5: unknown directive: toolchain ``` [1]: https://github.com/jetstack/jetstack-secure/actions/runs/10375056958/job/28723891036?pr=552
Signed-off-by: Richard Wall <[email protected]>
wallrj
force-pushed
the
VC-35373-venafi-connection-helm-chart
branch
from
c9f05bb to
59901a7
Compare
wallrj
changed the title
maelvls
force-pushed
the
venconn
branch
3 times, most recently
from
e2545c6 to
f1f175c
Compare
|
Supplanted by #559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #552
Ref: VC-35373