Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selector labels for Deployment and Service #141

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Update selector labels for Deployment and Service #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f42135
Update selector labels
logand22 Dec 4, 2023
535e628
Merge branch 'main' into logan/fix-helm-chart
joshw123 Feb 21, 2024
95c7b9e
Merge branch 'main' into logan/fix-helm-chart
joshw123 Feb 21, 2024
e89810b
Merge branch 'main' into logan/fix-helm-chart
davidcollom Feb 21, 2024
86109a2
Merge branch 'main' into logan/fix-helm-chart
davidcollom Feb 21, 2024
2604c16
Merge branch 'main' into logan/fix-helm-chart
davidcollom Feb 23, 2024
de83557
Create selector helper instead
logand22 Feb 23, 2024
9f4b4f3
Merge branch 'main' into logan/fix-helm-chart
logand22 Mar 4, 2024
cbab519
Merge branch 'main' into logan/fix-helm-chart
logand22 Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions deploy/charts/version-checker/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,11 @@ app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- end -}}

{{/*
Common selector
*/}}
{{- define "version-checker.selector" -}}
app.kubernetes.io/name: {{ include "version-checker.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end -}}
2 changes: 1 addition & 1 deletion deploy/charts/version-checker/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ spec:
replicas: {{ .Values.replicaCount }}
selector:
matchLabels:
{{- include "version-checker.labels" . | nindent 6 }}
{{- include "version-checker.selector" . | nindent 6 }}
template:
metadata:
labels:
Expand Down
2 changes: 1 addition & 1 deletion deploy/charts/version-checker/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ spec:
protocol: TCP
name: web
selector:
{{ include "version-checker.labels" . | nindent 4 }}
{{- include "version-checker.selector" . | nindent 4 }}
Loading