-
Notifications
You must be signed in to change notification settings - Fork 80
Adding http metrics to calculate upstream response times #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -51,18 +51,23 @@ func NewCommand(ctx context.Context) *cobra.Command { | |||
return fmt.Errorf("failed to build kubernetes client: %s", err) | |||
} | |||
|
|||
metrics := metrics.New(log) | |||
if err := metrics.Run(opts.MetricsServingAddress); err != nil { | |||
metricsServer := metrics.NewServer(log) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to prevent a name collision from the metrics package
There's a bit too much going on for me to fully review. @davidcollom could you maybe add some screenshots of the metric added so I can see the benefit from a user perspective? |
@hawksight Appreciate that there's a lot here! 🙈 , the outputted metrics are similar to the following:
|
Many of the time, performance issues can be related to the fact that the upstream is taking a lot longer to respond,
this can be when the number of container tags are published. There's hope here that we can monitor and observe the many API Calls performed to upstream services