optimize-js: Make it so that interconnected optimizations are either all applied or all ignored #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all applied or all ignored This fixes an issue where with alternate compilers like Lamdera, only some definitions of the mutatingJS functions got replaced but not others, changing the behavior of the code. Now these are grouped together and they only get applied if all of them get applied.
jfmengels
force-pushed
the
fix-breaking-optimizations
branch
from
db68db6 to
98eaadf
Compare
|
Released in 2.13.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where with alternate compilers like Lamdera, only some definitions of the mutatingJS functions got replaced but not others, changing the behavior of the code. Now these are grouped together and they only get applied if all of them get applied.