Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API Key suggestion from config command #1277

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Remove API Key suggestion from config command #1277

merged 1 commit into from
Oct 1, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Oct 1, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Following the API Key deprecation process, this PR removes the API Key suggestion (wording only) from the config command.
API Key will still be support in the CLI if the JPD supports it (see the link above for more details).

@RobiNino RobiNino added the improvement Automatically generated release notes label Oct 1, 2024
@RobiNino RobiNino requested a review from eyalbe4 October 1, 2024 11:27
@RobiNino RobiNino merged commit 1e7a45d into jfrog:dev Oct 1, 2024
6 of 7 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 11, 2024
Merged
@pspino pspino mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @eyalbe4