Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands to usage report #1299

Merged
merged 13 commits into from
Nov 13, 2024
Merged

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Nov 10, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR adds tracking for new command executions in the usage report:

config_oidc: Tracks the number of times the config command is executed with OIDC.
config : Track the amount of times JFrog server has been configured. ( Notice this includes Add or Edit operation for both OIDC and non OIDC )
rt_build_publish_auto: Tracks instances when builds are automatically published.

Tracking is enabled by setting specific environment variables in the setup-cli-action, which the CLI then reads to report usage data.

Note: The config command usage report only includes cases where config_oidc is used, as it is more useful to differentiate between "add" and "edit" operations rather than general config usage.

@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Nov 10, 2024
@EyalDelarea EyalDelarea changed the title Add commands usage report Add commands to usage report Nov 10, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


artifactory/commands/buildinfo/publish.go Outdated Show resolved Hide resolved
artifactory/commands/buildinfo/publish.go Outdated Show resolved Hide resolved
artifactory/commands/buildinfo/publish.go Outdated Show resolved Hide resolved
common/commands/config.go Outdated Show resolved Hide resolved
common/commands/config.go Outdated Show resolved Hide resolved
common/commands/config.go Outdated Show resolved Hide resolved
common/commands/config_test.go Outdated Show resolved Hide resolved
common/commands/config_test.go Show resolved Hide resolved
utils/coreutils/coreconsts.go Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea merged commit 727911a into jfrog:dev Nov 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants