Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Fix repositories were not found issue #879

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jul 27, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix the following issue:

11:02:45 [Debug] Sending HTTP GET request to: https://***/artifactory/api/storageinfo
11:02:45 [Debug] Artifactory response: 200
11:02:45 [Debug] Waiting for storage info calculation completion(Attempt 61)
11:02:45 [:rotating_light:Error] one or more of the requested repositories were not found

Root cause:
The GetFilteredRepositoriesByNameAndType REST API does not include the build-info repositories in its return results. However, if the build-info repository is federated, it will be included in the response of this REST API. In such a scenario, the build-info might appear twice in the return value of the method.

Solution
Exclude the build-info repositories from the GetFilteredRepositoriesByNameAndType() requests.

@yahavi yahavi added the bug Something isn't working label Jul 27, 2023
@yahavi yahavi requested review from eyalbe4 and talarian1 July 27, 2023 11:02
@yahavi yahavi self-assigned this Jul 27, 2023
@yahavi yahavi temporarily deployed to frogbot July 27, 2023 11:12 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@yahavi yahavi merged commit 17b0012 into jfrog:dev Jul 27, 2023
8 checks passed
@yahavi yahavi deleted the exclude-build-info branch July 27, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants