Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate rows and added scope for component name #890

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

asafambar
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@asafambar
Copy link
Contributor Author

asafambar commented Aug 7, 2023

  1. Curation Xray reports show for each direct dependencies all its blocked packages under curation. Under a direct dependency can be many packages which are similar under different paths, we want to present in the report only one occurrence for each package.

  2. Added scope for package name, scope is also part of the component name uniqueness,
    according to NPM official desperation of scope:

"All npm packages have a name. Some package names also have a scope. A scope follows the usual rules for package names (URL-safe characters, no leading dots or underscores). When used in package names, scopes are preceded by an @ symbol and followed by a slash, e.g.
@somescope/somepackagename ״

xray/commands/curation/audit.go Outdated Show resolved Hide resolved
xray/commands/curation/audit.go Outdated Show resolved Hide resolved
xray/commands/curation/audit_test.go Outdated Show resolved Hide resolved
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahavi yahavi added the bug Something isn't working label Aug 11, 2023
@yahavi yahavi merged commit aa6ed99 into jfrog:dev Aug 11, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants