-
Notifications
You must be signed in to change notification settings - Fork 116
Change Webhook Creation Criteria to behave more like UI/API #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
I wanted to follow up regarding my recent pull request. I understand that you may be busy, but I would appreciate any updates on whether it is being reviewed, if there are any issues or missing elements that I should address, or if the team is currently gathering pull requests for an upcoming release. Thank you for your time and attention! Best regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code look good to me. @mhadertelekom sorry for the delay.
I saw there were other pull requests already getting merged. Is this one missing something, that I need to deliver in order for it to be merged? Since this is my first time contributing I am not sure if I already covered all of the usual procedure. Thanks in advance! Michael |
@mhadertelekom Thanks for the PR contribution ! Sorry for the delay ! we are planning to accomodate in upcoming releases ( ETA ~ 2 weeks) . Will get back if any additional changes are required ! |
26481d3
to
eec8960
Compare
@mhadertelekom sorry for the delay response , Can you please update changelog file ? |
Hi @chukka , I have to say sorry for delayed response, too I was on vacation last 2 weeks. |
Hi everyone @chukka @alexhung @soumyas-dev , it seems this issue is getting more and more delayed, apparently some of the tests are failing. Regards, Michael |
Update Webhook Creation Criteria to Align with Artifactory UI/API Behavior
Description:
Currently the creation of release-bundle-webhook-resources has a different policy inside the terraform provider than in the API or UI. The field "registered_release_bundle_names" is mandatory inside the terraform provider. UI/API behave differently.
This pull request:
These improvements ensure a more intuitive user experience for customers managing Artifactory webhooks via Terraform.