Skip to content

Change Webhook Creation Criteria to behave more like UI/API #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mhadertelekom
Copy link

Update Webhook Creation Criteria to Align with Artifactory UI/API Behavior

Description:

Currently the creation of release-bundle-webhook-resources has a different policy inside the terraform provider than in the API or UI. The field "registered_release_bundle_names" is mandatory inside the terraform provider. UI/API behave differently.

This pull request:

  1. Refines the webhook creation logic in the Terraform provider for Artifactory to better align with the behavior of the Artifactory UI and API
  2. Aligns the tests that are done in the Terraform provider according to the changes from (1)
  3. Updates the documentation accordingly

These improvements ensure a more intuitive user experience for customers managing Artifactory webhooks via Terraform.

Copy link

github-actions bot commented Feb 25, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@alexhung alexhung added the enhancement New feature or request label Feb 25, 2025
@mhadertelekom
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@mhadertelekom mhadertelekom marked this pull request as ready for review February 28, 2025 12:31
@mhadertelekom
Copy link
Author

Hi @alexhung and @chukka,

I wanted to follow up regarding my recent pull request. I understand that you may be busy, but I would appreciate any updates on whether it is being reviewed, if there are any issues or missing elements that I should address, or if the team is currently gathering pull requests for an upcoming release.

Thank you for your time and attention!

Best regards,
Michael

Copy link

@alexhung alexhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code look good to me. @mhadertelekom sorry for the delay.

@mhadertelekom
Copy link
Author

Hi again @alexhung , @chukka,

I saw there were other pull requests already getting merged. Is this one missing something, that I need to deliver in order for it to be merged? Since this is my first time contributing I am not sure if I already covered all of the usual procedure.

Thanks in advance!

Michael

@chukka
Copy link
Collaborator

chukka commented Apr 5, 2025

@mhadertelekom Thanks for the PR contribution ! Sorry for the delay ! we are planning to accomodate in upcoming releases ( ETA ~ 2 weeks) . Will get back if any additional changes are required !

@chukka chukka force-pushed the mh-feature/webhooks branch from 26481d3 to eec8960 Compare June 9, 2025 05:56
@chukka
Copy link
Collaborator

chukka commented Jun 9, 2025

@mhadertelekom sorry for the delay response , Can you please update changelog file ?

@mhadertelekom
Copy link
Author

Hi @chukka ,

I have to say sorry for delayed response, too I was on vacation last 2 weeks.
Changelog is now updated.

@mhadertelekom
Copy link
Author

Hi everyone @chukka @alexhung @soumyas-dev ,

it seems this issue is getting more and more delayed, apparently some of the tests are failing.
When I ran the tests in February, everything went smoothly.
Would a meeting maybe help to get things sorted here?

Regards,

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants