Skip to content

Added disable proxy attribute for single replication #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025

Conversation

soumyas-dev
Copy link
Contributor

@soumyas-dev soumyas-dev commented Jul 1, 2025

Problem

The local_repository_single_replication Terraform resource was missing support for the disableProxy setting. This made it impossible to manage or disable the proxy configuration for single replication local repositories via Terraform. As a result, users could not control this setting from their IaC workflow, potentially leaving proxies enabled unintentionally.

Example Scenario

A user attempts to provision a local repository with single replication in Artifactory but cannot disable the proxy, as the resource's schema does not accept a disableProxy field:

resource "artifactory_local_repository_single_replication" "example" {
  // ... other settings ...
  // disableProxy = true  # Not supported in previous provider versions
}

Solution

This PR adds support for the disableProxy attribute to the local_repository_single_replication resource.

Example Usage

resource "artifactory_local_repository_single_replication" "example" {
  // ... other settings ...
  disableProxy = true
}

This addition aligns the Terraform provider's capabilities with the Artifactory API and UI, enabling a more complete and user-friendly experience for managing repository replication settings.

Fixes : #1255

@soumyas-dev soumyas-dev requested a review from a team July 1, 2025 11:35
@soumyas-dev soumyas-dev self-assigned this Jul 1, 2025
@soumyas-dev soumyas-dev requested a review from chukka as a code owner July 1, 2025 11:35
@soumyas-dev soumyas-dev added the enhancement New feature or request label Jul 1, 2025
Copy link
Collaborator

@srinivasgowda097 srinivasgowda097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinivasgowda097 srinivasgowda097 merged commit d4e450b into master Jul 8, 2025
9 checks passed
@srinivasgowda097 srinivasgowda097 deleted the disable-proxy-support branch July 8, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local_repository_single_replication missing disableProxy
3 participants