-
Notifications
You must be signed in to change notification settings - Fork 115
Added disable proxy attribute for single replication #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasgowda097
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
local_repository_single_replication
Terraform resource was missing support for thedisableProxy
setting. This made it impossible to manage or disable the proxy configuration for single replication local repositories via Terraform. As a result, users could not control this setting from their IaC workflow, potentially leaving proxies enabled unintentionally.Example Scenario
A user attempts to provision a local repository with single replication in Artifactory but cannot disable the proxy, as the resource's schema does not accept a
disableProxy
field:Solution
This PR adds support for the
disableProxy
attribute to thelocal_repository_single_replication
resource.Example Usage
This addition aligns the Terraform provider's capabilities with the Artifactory API and UI, enabling a more complete and user-friendly experience for managing repository replication settings.
Fixes : #1255