fix: invalid check in remote content sync logic

[wywywywy]

Fixing a mistake introduced in #1274

The checks here are the wrong way round.

This causes a fatal error if the repository doesn't have the contentSynchronisation attribute.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[wywywywy]

I have read the CLA Document and I hereby sign the CLA

[wywywywy]

recheck

[srinivasgowda097]

@wywywywy : Could you please share a sample example where it is failing with a fatal error, and also mention the provider version?

[wywywywy]

Broken in v12.9.6, worked in v12.9.5.

Do a terraform plan with token that's not a project admin. When it's not a project admin, the GET request of the repositories REST API call doesn't return the contentSynchronisation attribute.

[wywywywy]

This is the relevant line in v12.9.5

terraform-provider-artifactory/pkg/artifactory/resource/repository/remote/remote.go

Line 249 in 114130e

if apiModel.ContentSynchronisation != nil && apiModel.ContentSynchronisation.Enabled {

[srinivasgowda097]

@wywywywy Here is the PR: #1295, which addresses your use case. We are closing your PR, as it comprehensively covers all relevant combinations

[wywywywy]

Thanks. I'll retest when the new version is released.

[srinivasgowda097]

@wywywywy v12.10.0 is released.