Skip to content

Modified the validation rules and included property based attributes for the package cleanup policy #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2025
Merged

Modified the validation rules and included property based attributes for the package cleanup policy #1293

merged 2 commits into from
Jul 18, 2025
+1,562 −595

Conversation

srinivasgowda097
Copy link
Collaborator

@srinivasgowda097 srinivasgowda097 commented Jul 12, 2025 •
edited
Loading

  • Added included_properties and excluded_properties attributes
  • Fixed and added validation for time-based, version-based and properties-based conditions
  • Added days-based time conditions (created_before_in_days, last_downloaded_before_in_days)

Fixes : #1285, #1289 and #1290

@srinivasgowda097 srinivasgowda097 requested a review from chukka as a code owner July 12, 2025 16:50
@srinivasgowda097 srinivasgowda097 force-pushed the modify_cleanup_policy_attri branch from 7d5532b to fa38f8c Compare July 14, 2025 05:42
@srinivasgowda097 srinivasgowda097 force-pushed the modify_cleanup_policy_attri branch from fa38f8c to ea0dbd8 Compare July 14, 2025 14:51
@srinivasgowda097 srinivasgowda097 force-pushed the modify_cleanup_policy_attri branch from ea0dbd8 to 13c0df6 Compare July 14, 2025 16:06
shahiinn
shahiinn previously approved these changes Jul 17, 2025
View reviewed changes
@srinivasgowda097 srinivasgowda097 force-pushed the modify_cleanup_policy_attri branch from 728c05a to 0ca9de9 Compare July 17, 2025 11:21
@srinivasgowda097 srinivasgowda097 force-pushed the modify_cleanup_policy_attri branch from a0212b3 to 2c43b08 Compare July 18, 2025 04:13
@srinivasgowda097 srinivasgowda097 merged commit 6c28140 into master Jul 18, 2025
3 checks passed
@srinivasgowda097 srinivasgowda097 deleted the modify_cleanup_policy_attri branch July 18, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chukka chukka chukka approved these changes

@shahiinn shahiinn shahiinn approved these changes

@RobinDuhan RobinDuhan RobinDuhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unabled to create a package cleanup policy with keep_last_n_versions
5 participants
@srinivasgowda097 @chukka @shahiinn @RobinDuhan @jfrogsolutioncicd