provider config: warn instead of error if xray version can't be obtained #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
aliculPix4D
commented
Jul 24, 2025
| @@ -159,7 +159,7 @@ func (p *XrayProvider) Configure(ctx context.Context, req provider.ConfigureRequ | |||
|
|
|||
| version, err := util.GetXrayVersion(restyClient) | |||
| if err != nil { | |||
| resp.Diagnostics.AddError( | |||
| resp.Diagnostics.AddWarning( | |||
| "Error getting Xray version", | |||
There was a problem hiding this comment.
Maybe: Unable to fetch Xray version is better fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provider config: warn instead of error if xray version can't be obtained
Alternative solution:
Add a new option to the provider configuration schema e.g.
xray_version_check: boolwith true being the default behaviour. A long time ago, Artifactory Terraform provider had the similarcheck_licenceoption in the configuration schemaCloses: #338