Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #114 and improved workflows #115

Merged
merged 2 commits into from
May 13, 2024

Conversation

hpsaturn
Copy link
Collaborator

@hpsaturn hpsaturn commented May 8, 2024

Description

Fixed issue #114 around the CI improvement. Also was added a new workflow for a possible devel branch.

@jgauchia
Copy link
Owner

jgauchia commented May 10, 2024

HI @hpsaturn , this PR is for master branch ? maybe better in dev branch , or doesn't matter (or both). Thank you

@hpsaturn
Copy link
Collaborator Author

in the master, because affects the all branches. Each branch or in progress PR should perform a sync (git pull from master to its branches)

@hpsaturn
Copy link
Collaborator Author

forgot say that it should be with master target because in the dev branches the checks will fail. But again, when we will have the dev fix, and the sync with this new master, the dev branches will be ok.

@jgauchia jgauchia merged commit d748d08 into jgauchia:master May 13, 2024
1 check passed
@hpsaturn hpsaturn deleted the impro_ci_for_all_envs branch May 16, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants