Skip to content

Audio fix and other minor changes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gummygamer
Copy link

An attempted improvement of the emulator. Mainly added audio support. It took a while to get my changes in a clean commit, and I hope this is correct and useful. I believe the audio is still not perfect, but it should be a step in the right direction. I'm aware that some files have comments in Portuguese. If you are interested in the changes, I can fix that.

@jgilchrist
Copy link
Owner

@Gummygamer Thanks so much for your interest in the project and for working on this! I've tried this out and it sounds great 🙂

I'm afraid though that gbemu is a personal project for me and so I'd be looking to implement audio support myself at some point to learn how it's done. As a result I'm afraid I wouldn't merge a PR for this, but I'm happy to leave this up as reference for other people who are interested (and perhaps for myself when I get round to implementing it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants