POC: Add more colours #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Keith Cirkel <[email protected]>
elenatanasoiu
force-pushed
the
keith-elena/colours
branch
from
aac2abd to
732a9ec
Compare
joshuay03
force-pushed
the
keith-elena/colours
branch
from
732a9ec to
fe87e37
Compare
elenatanasoiu
force-pushed
the
keith-elena/colours
branch
from
fe87e37 to
8a3cd45
Compare
Makes the logic simpler. We initially made this a special check at the start as it would be confused with cfunc. But I can see there are spans further down in the stack like "Array#each" that will be detected as "Kernel" so I think it's ok to just treat this "Kernel" category as all the other ones. This matches what speedscope does as well.
It's magenta.
|
Did a bit of refactoring to extract the nested if statements into methods. And changed some colours. Here's a fresh profile:
|
|
Thanks for fixing the failing CI @joshuay03! 🙇♀️ |
joshuay03
reviewed
Jan 26, 2025
There was a problem hiding this comment.
Thank you for the PR. I like this, but I’ll leave the approval (specifically regarding the choice of colours) to @jhawthorn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keithamus and I paired on a POC for this.
The colours are totally random right now, but this was a fun little foray into making Vernier look more like speedscope. Looking for feedback.
Example JSON profile:
pickles.json
How to get a JSON profile with colours:
The list of available colours is here:
https://github.com/firefox-devtools/profiler/blob/9175e2462bedd013adcf97acb28bda50c54791a9/src/utils/colors.js#L103-L175