Skip to content

Conversation

@qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Oct 25, 2025

Fix #31126

@qmonmert qmonmert force-pushed the mysql940 branch 2 times, most recently from fcc51df to 3fcb1f0 Compare October 25, 2025 20:29
@qmonmert qmonmert changed the title bump mysql from 9.2.0 to 9.4.0 Fix: bump mysql from 9.2.0 to 9.5.0 Oct 25, 2025
@qmonmert qmonmert force-pushed the mysql940 branch 3 times, most recently from a235093 to 510e68d Compare October 26, 2025 15:01
@qmonmert qmonmert marked this pull request as ready for review October 26, 2025 15:50
@qmonmert qmonmert requested review from DanielFran and mshima October 26, 2025 15:50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testcontainer configuration file should be implemented in spring-data-relational generator.
This is a testcontainer configuration correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my.cnf is a MySQL config file. We need to have the same in src/main/docker/config/mysql/my.cnf and in src/test/resources/conf/my.cnf

Copy link
Member

@mshima mshima Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I understand, but this generator generates docker compose files only.
It’s not related to testcontainers.
JHipster Node/Dotnet will have src/test/resources files generated too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I do that, thanks @mshima

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants