-
-
Couldn't load subscription status.
- Fork 4.1k
Fix: bump mysql from 9.2.0 to 9.5.0 #31160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fcc51df to
3fcb1f0
Compare
a235093 to
510e68d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testcontainer configuration file should be implemented in spring-data-relational generator.
This is a testcontainer configuration correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my.cnf is a MySQL config file. We need to have the same in src/main/docker/config/mysql/my.cnf and in src/test/resources/conf/my.cnf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I understand, but this generator generates docker compose files only.
It’s not related to testcontainers.
JHipster Node/Dotnet will have src/test/resources files generated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I do that, thanks @mshima
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fix #31126