Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jooq module #11107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fabienpuissant
Copy link
Collaborator

@fabienpuissant fabienpuissant commented Oct 12, 2024

ci test not relevant because need a database up to install with this jooq plugin, cannot test on mssql. Error to connect due to url error.

@fabienpuissant fabienpuissant marked this pull request as draft October 12, 2024 23:05
@fabienpuissant fabienpuissant force-pushed the jooq-module branch 4 times, most recently from bed27c6 to b9a7721 Compare October 30, 2024 21:51
@fabienpuissant fabienpuissant changed the title [WIP] Add jooq module Add jooq module Oct 30, 2024
@fabienpuissant fabienpuissant marked this pull request as ready for review October 30, 2024 21:52
@pascalgrimaud
Copy link
Member

for the CI test, you can create a new dedicated config with what you need to test jooq

Another idea would be to add it to mariadb, it should work: https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh#L232-L239

@fabienpuissant
Copy link
Collaborator Author

fabienpuissant commented Oct 31, 2024

for the CI test, you can create a new dedicated config with what you need to test jooq

Another idea would be to add it to mariadb, it should work: https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh#L232-L239

But the plugin connects to a database to introspect schema and generate classes depending on what tables exists.
Is it possible in the test ci to have a docker container up with a database ready to be connected to ?

@pascalgrimaud
Copy link
Member

Here some steps in the GitHub CI:

@fabienpuissant
Copy link
Collaborator Author

Here some steps in the GitHub CI:

I started to investigate on it but in fact the db needs to be up at compile time not when we start the app, so on step "Test: verify: " Regarding the workflow, I don't think we have this use case and I don't find a proper way to do it

Here an example : https://github.com/fabienpuissant/jhipster-lite/actions/runs/11622943610/job/32369374084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants