Fix update-test-outputs script to use test-specific prettier options.#741
Merged
jtkiesel merged 1 commit intojhipster:mainfrom Jul 6, 2025
Merged
Fix update-test-outputs script to use test-specific prettier options.#741jtkiesel merged 1 commit intojhipster:mainfrom
jtkiesel merged 1 commit intojhipster:mainfrom
Conversation
jtkiesel
reviewed
Jul 5, 2025
Contributor
jtkiesel
left a comment
There was a problem hiding this comment.
Thank you for this contribution! It will certainly make testing the printer much easier during development. I added a couple suggestions for minor improvements, let me know what you think.
packages/prettier-plugin-java/test/unit-test/binary_expressions/binary_expressions-spec.ts
Outdated
Show resolved
Hide resolved
c3660c5 to
86c10f7
Compare
Contributor
Author
|
Thanks for the feedback. I think I addressed your points by renaming the files to .prettierrc.json and by removing the prettierOptions parameter in favor of always loading .prettierrc.json instead. |
jtkiesel
approved these changes
Jul 6, 2025
Contributor
jtkiesel
left a comment
There was a problem hiding this comment.
Thank you for the quick changes and the rebase! It looks great. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, checking out the project and running update-test-outputs would make changes to the test outputs.
The change here is to use the test-specific configuration while recording tests. With this change, running npm run update-test-outputs doesn't make any changes to any files.