-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from askama to rinja #155
base: main
Are you sure you want to change the base?
Conversation
@@ -237,19 +237,19 @@ | |||
{%- endif %} | |||
{%- endmacro %} | |||
|
|||
{%- macro async(func) %} | |||
{%- macro is_async(func) %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This renaming and the ones below are required because rinja doesn't allow Rust keywords as macro names. I'm not sure if the names are particularly great but this follows what uniffi-rs itself does.
I don't think this relies on uniffi-rs, but there maybe some more |
I haven't dug deeply but this error looked as if it was still pulling in askama (even though its not a direct dependency anymore) and the only crate that appears to do it was from uniffi-rs.
Maybe that error is just a surrogate though? |
That's strange. Unless you still have |
Poking at it a little, the build fails on a number of statements in the templates, for instance:
If I'm reading things correctly, that function bubbles up into |
Ah then until you use the latest version, I suppose you'll have the issue. |
Fixes: #150
I started working on this before realizing it'll first require a new release of uniffi-rs. So leaving this here as a draft to be picked up again later.