Fix ncu_parser for different csv column count #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Environment
Bug report
When the original
ncu_parser.py
parses the output CSV file generated by ncu, it asserts the number of metrics of each row is 12. While in my setting it is 15, it skips all the lines.gpudb-char-and-opt/report_parser/ncu_parser.py
Lines 146 to 147 in 0395d20
Fix
While the number of metrics may differs in different ncu versions, a flexible way may be filtering the invalid row according to the actual metric number achieved from the first row.