Fix byte compilation errors for Emacs 31 (snapshot) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 55.65% 55.94% +0.28%
==========================================
Files 1 1
Lines 884 883 -1
==========================================
+ Hits 492 494 +2
+ Misses 392 389 -3 ☔ View full report in Codecov by Sentry. |
This reverts commit 0d02397.
Currently "ignore error" simply means that installation failures, e.g. byte-compilation errors, will be ignored. Tests still run in that case and failed tests will fail CI. Instead: - We require installation to succeed unconditionally, even for ignore-error matrix runs; - We ignore error on test-run steps; - We upload coverage only if all tests pass + the test-running succeeds end-to-end
This reverts commit fa5adb6.
jinnovation
force-pushed
the
fix-snapshot
branch
from
5a0e8f9 to
214f09a
Compare
jinnovation
commented
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.