Skip to content

Resolves HtmlSanitizer.js XSS Security Vulnerability #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolves HtmlSanitizer.js XSS Security Vulnerability #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions HtmlSanitizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//JavaScript HTML Sanitizer v2.0.3, (c) Alexander Yumashev, Jitbit Software.
//JavaScript HTML Sanitizer v2.0.4, (c) Alexander Yumashev, Jitbit Software.

//homepage https://github.com/jitbit/HtmlSanitizer

Expand Down Expand Up @@ -91,8 +91,12 @@ const HtmlSanitizer = new (function () {

let resultElement = makeSanitizedCopy(doc.body);

return resultElement.innerHTML
.replace(/div><div/g, "div>\n<div"); //replace is just for cleaner code
// Get sanitized inner HTML
let sanitizedHtml = resultElement.innerHTML;

// Use DOMParser for safe beautification instead of regex replacement
let formatDoc = _parser.parseFromString("<body>" + sanitizedHtml + "</body>", "text/html");
return formatDoc.body.innerHTML;
}

function startsWithAny(str, substrings) {
Expand All @@ -108,4 +112,4 @@ const HtmlSanitizer = new (function () {
this.AllowedAttributes = _attributeWhitelist;
this.AllowedCssStyles = _cssWhitelist;
this.AllowedSchemas = _schemaWhiteList;
});
})();