Automatically use optimal Block Engine region #920
+425
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esemeniuc
force-pushed
the
eric/discovery-service
branch
3 times, most recently
from
91cf267 to
89a10a9
Compare
esemeniuc
commented
Jul 11, 2025
core/src/proxy/block_engine_stage.rs
Outdated
| })?; | ||
| Self::get_endpoint(local_block_engine_config.block_engine_url.clone())?; | ||
|
|
||
| if !local_block_engine_config.disable_block_engine_autoconfig { |
There was a problem hiding this comment.
use new discovery stuff here
esemeniuc
force-pushed
the
eric/discovery-service
branch
from
d0daeb8 to
f58d38f
Compare
esemeniuc
changed the title
esemeniuc
changed the title
jedleggett
reviewed
Jul 15, 2025
| @@ -121,7 +122,8 @@ impl BroadcastStageType { | |||
| bank_forks: Arc<RwLock<BankForks>>, | |||
| shred_version: u16, | |||
| quic_endpoint_sender: AsyncSender<(SocketAddr, Bytes)>, | |||
| shred_receiver_address: Arc<RwLock<Option<SocketAddr>>>, | |||
| shredstream_receiver_address: Arc<ArcSwap<Option<SocketAddr>>>, | |||
There was a problem hiding this comment.
what is the difference between shredstream_receiver_address and shred_receiver_address?
There was a problem hiding this comment.
1 is auto configured, 1 is manually configured. we dedup if they are the same
esemeniuc
force-pushed
the
eric/discovery-service
branch
from
f8f9e87 to
4f13711
Compare
esemeniuc
commented
Jul 15, 2025
| @@ -206,28 +400,6 @@ impl BlockEngineStage { | |||
| // Get a copy of configs here in case they have changed at runtime | |||
| let keypair = cluster_info.keypair().clone(); | |||
|
|
|||
| let mut backend_endpoint = | |||
There was a problem hiding this comment.
moved to endpoint parameter and get_endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes aimed at improving the handling of configuration by adding support for dynamic Block Engine endpoint discovery. Whenever the connection with the block engine is broken, we automatically try to connect to the best available region.
Changes:
pingutilitydisable_block_engine_autoconfigflag inBlockEngineConfigto allow users to bypass automatic endpoint discoveryRwLockwithArcSwapforshred_receiver_addressto avoid acquiring a lock per sent shred batch