chore: upgrade jito-solana deps to 2.3 - remove legacy operator client #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzalz
changed the title
gzalz
commented
Jul 21, 2025
| @@ -793,7 +794,11 @@ mod tests { | |||
| vote_account: &Pubkey, | |||
| delegation_amount: u64, | |||
| ) -> Pubkey { | |||
| let minimum_delegation = solana_stake_program::get_minimum_delegation(&bank.feature_set); | |||
| let minimum_delegation = solana_stake_program::get_minimum_delegation( | |||
There was a problem hiding this comment.
gzalz
commented
Jul 21, 2025
| @@ -351,7 +193,10 @@ async fn test_merkle_tree_generation() -> Result<(), Box<dyn std::error::Error>> | |||
| const PROTOCOL_FEE_BPS: u64 = 300; | |||
| const VALIDATOR_FEE_BPS: u16 = 1000; | |||
| const TOTAL_TIPS: u64 = 1_000_000; | |||
| let ncn_address = Pubkey::new_unique(); | |||
There was a problem hiding this comment.
I compared some debug output between master branch and this branch and found the NCN address generated by new_unique are different between these versions of solana-pubkey.
There was a problem hiding this comment.
Master:
Protocol fee recipient: De5mc7vkzwhCSWLeesKEJVxTTRyYJGiCjQmA9FnQ6Whd
Protocol fee amount: 30000
Validator fee amount: 100000
NCN address: 1111111QLbz7JHiBTspS962RLKV8GndWFwiEaqKM
Epoch + 1: 10000
TIP_ROUTER_ID: RouterBmuRBkPUbgEDMtdvTZ75GBdSREZR5uGUxxxpb
new_unique on solana-pubkey 2.4.0
Protocol fee recipient: 4x5nU6aZWuoRBcJvjnC3RAUdPeDwngRs8afnn34byK4d
Protocol fee amount: 30000
Validator fee amount: 100000
NCN address: 11157t3sqMV725NVRLrVQbAu98Jjfk1uCKehJnXXQs
Epoch + 1: 10000
TIP_ROUTER_ID: RouterBmuRBkPUbgEDMtdvTZ75GBdSREZR5uGUxxxpb
ebatsell
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution