Skip to content

Add Env for Shared document random name #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saghul merged 4 commits into from
Feb 3, 2025
Merged

Add Env for Shared document random name #1985

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
641c9c1
Add Env parameter for etherpad random name generation in Jicofo
daimoc Dec 20, 2024
b512697
Add conditional logic around ENABLE_SHARED_DOCUMENT_RANDOM_NAME
daimoc Dec 20, 2024
3771b57
Update jicofo/rootfs/defaults/jicofo.conf
daimoc Dec 20, 2024
e15287c
Use ENABLE_SHARED_DOCUMENT_RANDOM_NAME variable
daimoc Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ services:
- ENABLE_OCTO_SCTP
- ENABLE_RECORDING
- ENABLE_SCTP
- ENABLE_SHARED_DOCUMENT_RANDOM_NAME
- ENABLE_TRANSCRIPTIONS
- ENABLE_VISITORS
- ENABLE_AUTO_LOGIN
Expand Down
7 changes: 7 additions & 0 deletions jicofo/rootfs/defaults/jicofo.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
{{ $ENABLE_AUTO_LOGIN := .Env.ENABLE_AUTO_LOGIN | default "1" | toBool -}}
{{ $ENABLE_REST := .Env.JICOFO_ENABLE_REST | default "0" | toBool -}}
{{ $ENABLE_JVB_XMPP_SERVER := .Env.ENABLE_JVB_XMPP_SERVER | default "0" | toBool -}}
{{ $ENABLE_SHARED_DOCUMENT_RANDOM_NAME := .Env.ENABLE_SHARED_DOCUMENT_RANDOM_NAME | default "0" | toBool -}}
{{ $HEALTH_CHECKS_USE_PRESENCE := .Env.JICOFO_HEALTH_CHECKS_USE_PRESENCE | default "0" | toBool -}}
{{ $JIBRI_BREWERY_MUC := .Env.JIBRI_BREWERY_MUC | default "jibribrewery" -}}
{{ $JIGASI_BREWERY_MUC := .Env.JIGASI_BREWERY_MUC | default "jigasibrewery" -}}
Expand Down Expand Up @@ -187,6 +188,12 @@ jicofo {
enable-multi-stream-backward-compat = {{ .Env.JICOFO_MULTI_STREAM_BACKWARD_COMPAT | toBool }}
{{ end }}

{{ if $ENABLE_SHARED_DOCUMENT_RANDOM_NAME }}
shared-document {
use-random-name = {{ .Env.ENABLE_SHARED_DOCUMENT_RANDOM_NAME | toBool }}
}
{{ end }}

}

{{ if .Env.JICOFO_ENABLE_HEALTH_CHECKS }}
Expand Down