fix: Fail connectivity checks for non-keep-alive pairs #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers a case that was missed in jitsi#287. When multiple pairs are SUCCEEDED before we reach the TERMINATED state, we keep responding to them.
Member
|
Checkstyle failure, otherwise looks good. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
============================================
- Coverage 36.12% 35.82% -0.30%
+ Complexity 1124 1119 -5
============================================
Files 166 166
Lines 10989 10958 -31
Branches 1614 1618 +4
============================================
- Hits 3970 3926 -44
- Misses 6490 6498 +8
- Partials 529 534 +5
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| // After we've terminated, only respond for the selected pair | ||
| CandidatePair selected = getSelectedPair(knownPair.getParentComponent().getParentStream().getName()); | ||
| CandidatePair selected | ||
| = getSelectedPair(knownPair.getParentComponent().getParentStream().getName()); |
Member
There was a problem hiding this comment.
Tiny quibble, but shouldn't the equals sign go before the line break?
JonathanLennox
approved these changes
Nov 24, 2025
bgrozev
added a commit
to jitsi/jitsi-videobridge
that referenced
this pull request
Nov 25, 2025
* Update github action versions (jitsi/ice4j#301) * Update publishing to Maven central. (jitsi/ice4j#303) * log: Move verbose logs from INFO to DEBUG. (jitsi/ice4j#300) * fix: Fail connectivity checks for non-keep-alive pairs (jitsi/ice4j#304) * feat: Option to send to the last received from address. (jitsi/ice4j#305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a case that was missed in #287. When multiple pairs
are SUCCEEDED before we reach the TERMINATED state, we keep responding
to them.