feat(transcription): Drops TranscriberManager and expects dialIQ. #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrozev
previously approved these changes
Sep 4, 2024
bgrozev
force-pushed
the
non-moderator-features
branch
from
e024294
to
c9cf2c1
Compare
| @@ -96,6 +97,14 @@ open class JigasiDetector( | |||
| transcriberCount.set(getInstanceCount { it.supportsTranscription() }.toLong()) | |||
| } | |||
|
|
|||
| fun hasTranscriber(chatRoom: ChatRoom?): Boolean { | |||
| chatRoom?.let { | |||
| chatRoom.members.firstOrNull { member -> member.isTranscriber } != null | |||
There was a problem hiding this comment.
Semantically this should be any not firstOrNull != null
JonathanLennox
previously approved these changes
Sep 13, 2024
damencho
force-pushed
the
non-moderator-features
branch
from
7a46da4
to
71e3436
Compare
damencho
force-pushed
the
non-moderator-features
branch
from
71e3436
to
b3cc809
Compare
JonathanLennox
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.