Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage 1 #1

Merged
merged 25 commits into from
Nov 15, 2021
Merged

Stage 1 #1

merged 25 commits into from
Nov 15, 2021

Conversation

mihhu
Copy link
Member

@mihhu mihhu commented Nov 3, 2021

Implemented a web SDK that exposes the following functionality:

  • A generic React component encapsulating the iframe API - JitsiMeeting
  • Another React component that wraps the former, but it's auto configured for JaaS (the domain defaults to 8x8.vc, the tenant is required) - JaaSMeeting
  • A framework agnostic way to dynamically load the external API (support fo JaaS included) - initExternal
  • TypeScript types for JitsiMeetExternalAPI - ./types

quitrk
quitrk requested changes Nov 4, 2021
View reviewed changes
horymury
horymury reviewed Nov 4, 2021
View reviewed changes
saghul
saghul reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Left some comments, PTAL. Can you please also add a GH action to run the tests?

horymury
horymury requested changes Nov 4, 2021
View reviewed changes
saghul
saghul reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more comments. PTAL! Let's land version 0.0.1 after those are addressed and move forward, we can make further improvements later.

horymury
horymury reviewed Nov 11, 2021
View reviewed changes
saghul
saghul reviewed Nov 15, 2021
View reviewed changes
@quitrk quitrk self-requested a review November 15, 2021 10:36
@horymury horymury merged commit f384f3b into jitsi:main Nov 15, 2021
@saghul
Copy link
Member

saghul commented Nov 15, 2021

Excellent work @mihhu !

@mihhu mihhu deleted the stage-1 branch April 8, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul left review comments

@quitrk quitrk quitrk approved these changes

@horymury horymury horymury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihhu @saghul @quitrk @horymury