Better random #1081
Merged
Better random #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for a home-grown 8 16 char random string.
- Generate actually unique GUIDs - Use a better random character generator - Use a better alphabet for join codes which eliminates ambiguity
andrei-gavrilescu
approved these changes
Aug 14, 2024
| @@ -1,12 +1,87 @@ | |||
| /** | |||
| * Helper class to generate random values one by one, using an auxiliary | |||
| /** | ||
| * This alphabet removes all potential ambiguous symbols, so it's well suited for a code. | ||
| */ | ||
| const BASE32 = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ234567'; |
There was a problem hiding this comment.
This is cuel. Something comes to mind though, users won't know that they can only enter non ambiguous chars, so on the remote side when they enter the code they still might confuse 0 with O, maybe remove O and I as well.
There was a problem hiding this comment.
I'd like to stay with the base32 standard. A monospaced font should take care of that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, got nerdsnipped and now you have you review this :-P